Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 782273004: MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''. (Closed)

Created:
6 years ago by balazs.kilvady
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''. Fix d2e54925caa8b14988a46a912a8b061bf4c6cbf3 In 'MIPS: Change CmpWeakValue to a more MIPS like GetWeakValue.' a25003cfa6eac88635c12b51ec6ad74fed0d91a1 we switched to use GetWeakValue. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/ic/mips/ic-compiler-mips.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
6 years ago (2014-12-10 12:39:39 UTC) #2
dusmil.imgtec
LGTM.
6 years ago (2014-12-10 12:41:01 UTC) #3
ulan
LGTM, I didn't notice that the function was changed in mips.
6 years ago (2014-12-10 12:41:37 UTC) #4
balazs.kilvady
On 2014/12/10 12:41:37, ulan wrote: > LGTM, I didn't notice that the function was changed ...
6 years ago (2014-12-10 12:45:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782273004/1
6 years ago (2014-12-10 12:46:06 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-10 13:13:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698