Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 782273002: Do the early return when role is different than UnknownRole. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do the early return when role is different than UnknownRole. We do not need to call ariaRoleAttribute() to check whether current role is different than UnknownRole. Just check m_ariaRole instead. BUG= TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/modules/accessibility/AXTableRow.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782273002/1
6 years ago (2014-12-08 14:55:48 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-08 14:55:52 UTC) #4
k.czech
6 years ago (2014-12-08 14:57:32 UTC) #5
dmazzoni
lgtm
6 years ago (2014-12-08 16:44:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782273002/1
6 years ago (2014-12-08 16:44:51 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 17:50:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186711

Powered by Google App Engine
This is Rietveld 408576698