Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 782243003: Remove temporary code in FullscreenController and WebWidgetClient. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
5 years, 11 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@webframeclient_fullscreen
Project:
blink
Visibility:
Public.

Description

Remove temporary code in FullscreenController and WebWidgetClient. This is part of a multi-sided CLs: Part 1: https://codereview.chromium.org/790543003/ Part 2: https://codereview.chromium.org/789533002/ Part 3: <this> BUG=374854 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189024

Patch Set 1 #

Patch Set 2 : rebase and fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M Source/web/FullscreenController.cpp View 1 3 chunks +5 lines, -14 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-08 20:19:09 UTC) #2
Mike West
Deleted code is best code. LGTM.
6 years ago (2014-12-09 14:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782243003/20001
5 years, 11 months ago (2015-01-27 10:22:20 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 11:48:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189024

Powered by Google App Engine
This is Rietveld 408576698