Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 782083002: Add requests to third party. (Closed)

Created:
6 years ago by rnephew (Reviews Here)
Modified:
6 years ago
Reviewers:
Daniel Berlin, klundberg, cpu_(ooo_6.6-7.5), jbudorick, open-source-third-party-reviews, security, jschuh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add requests to third party. Requests is already mirrored on chromium. It has an Appache 2.0 license. It is required for the appurify python api found in thirdparty to work. BUG=439624 Committed: https://crrev.com/7b35188a8c7f9e5336b30afc453e4d9b3b65e62e Cr-Commit-Position: refs/heads/master@{#307993}

Patch Set 1 #

Total comments: 2

Patch Set 2 : change git revision number #

Patch Set 3 : fix path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, --1 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/requests/LICENSE View 1 chunk +68 lines, -0 lines 0 comments Download
A + third_party/requests/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/requests/README.chromium View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
rnephew (Reviews Here)
6 years ago (2014-12-05 23:27:42 UTC) #2
cpu_(ooo_6.6-7.5)
please follow http://www.chromium.org/developers/adding-3rd-party-libraries ping me back when you get the other two reviews as stated ...
6 years ago (2014-12-08 21:09:20 UTC) #3
Daniel Berlin
LGTM for OSTPR
6 years ago (2014-12-09 01:15:38 UTC) #5
jschuh
lgtm for security since it's test-only
6 years ago (2014-12-11 18:48:52 UTC) #6
jbudorick
https://codereview.chromium.org/782083002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/782083002/diff/1/DEPS#newcode499 DEPS:499: Var('chromium_git') + '/external/github.com/kennethreitz/requests.git' + '@' + '4e90aa7bd0c8051fe4894971fb77c72a26a92728', Roll this ...
6 years ago (2014-12-11 18:59:44 UTC) #7
rnephew (Reviews Here)
https://codereview.chromium.org/782083002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/782083002/diff/1/DEPS#newcode499 DEPS:499: Var('chromium_git') + '/external/github.com/kennethreitz/requests.git' + '@' + '4e90aa7bd0c8051fe4894971fb77c72a26a92728', On 2014/12/11 ...
6 years ago (2014-12-11 19:02:41 UTC) #8
jbudorick
lgtm
6 years ago (2014-12-11 19:15:33 UTC) #9
cpu_(ooo_6.6-7.5)
lgtm
6 years ago (2014-12-11 20:12:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782083002/40001
6 years ago (2014-12-11 20:22:47 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-11 23:11:34 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-11 23:13:12 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7b35188a8c7f9e5336b30afc453e4d9b3b65e62e
Cr-Commit-Position: refs/heads/master@{#307993}

Powered by Google App Engine
This is Rietveld 408576698