Issue 782043002: Tidy up WorkerConsoleAgent's handling of its WorkerGlobalScope reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 782043002: Tidy up WorkerConsoleAgent's handling of its WorkerGlobalScope reference. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Tidy up WorkerConsoleAgent's handling of its WorkerGlobalScope reference. With Oilpan, have the console agent correctly trace its WorkerGlobalScope reference. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186645

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	Source/core/inspector/WorkerConsoleAgent.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/core/inspector/WorkerConsoleAgent.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782043002/1

6 years ago (2014-12-06 13:30:00 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-06 14:08:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186645

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages