Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 782013002: Android: decouple mojo shell from the network service. (Closed)

Created:
6 years ago by ppi
Modified:
6 years ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@build-rule-for-the-network-service
Project:
mojo
Visibility:
Public.

Description

Android: decouple mojo shell from the network service. This patch removes the network service dependencies from the mojo shell. Instead, the standalone network service app is packaged with the mojo shell as an asset and run using Android handler. BUG=437290 R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/170449df75e23f593f9f7b3128c58a7fc3c87524

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Rebase. #

Patch Set 3 : Address Ben's comments. #

Patch Set 4 : Rebase. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -169 lines) Patch
M shell/BUILD.gn View 1 4 chunks +1 line, -4 lines 1 comment Download
M shell/android/apk/src/org/chromium/mojo_shell_apk/AndroidHandler.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo_shell_apk/FileHelper.java View 1 1 chunk +12 lines, -6 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 1 2 3 chunks +42 lines, -8 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellApplication.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M shell/android/library_loader.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M shell/android/mojo_main.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M shell/context.cc View 1 2 chunks +3 lines, -11 lines 0 comments Download
M shell/mojo_url_resolver.h View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M shell/mojo_url_resolver.cc View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
D shell/network_application_loader.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
D shell/network_application_loader.cc View 1 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ppi
ptal (this needs https://codereview.chromium.org/780043002/)
6 years ago (2014-12-05 16:50:15 UTC) #3
qsr
https://codereview.chromium.org/782013002/diff/20001/mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java File mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java (right): https://codereview.chromium.org/782013002/diff/20001/mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java#newcode25 mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java:25: private static final String NETWORK_LIBRARY_APP = "network_service.mojo"; Can you ...
6 years ago (2014-12-05 17:02:58 UTC) #4
ppi
Thanks, ptal. https://codereview.chromium.org/782013002/diff/20001/mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java File mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java (right): https://codereview.chromium.org/782013002/diff/20001/mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java#newcode25 mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java:25: private static final String NETWORK_LIBRARY_APP = "network_service.mojo"; ...
6 years ago (2014-12-10 16:21:00 UTC) #5
qsr
lgtm
6 years ago (2014-12-11 08:48:23 UTC) #6
ppi
Committed patchset #4 (id:80001) manually as 170449df75e23f593f9f7b3128c58a7fc3c87524 (presubmit successful).
6 years ago (2014-12-11 10:00:20 UTC) #7
jamesr
6 years ago (2014-12-11 19:16:58 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/782013002/diff/80001/shell/BUILD.gn
File shell/BUILD.gn (left):

https://codereview.chromium.org/782013002/diff/80001/shell/BUILD.gn#oldcode275
shell/BUILD.gn:275: "//net",
woohoo!! nicely done

Powered by Google App Engine
This is Rietveld 408576698