Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 781993002: Add UseCounters for some (now) non-standard CSS APIs (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis, shend
Project:
blink
Visibility:
Public.

Description

Add UseCounters for some (now) non-standard CSS APIs CSSKeyframesRule.appendRule is the now-standard name for CSSKeyframesRule.insertRule, but measure both to get a better idea of when dropping the old name is appropriate. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleMedia.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-05 16:17:44 UTC) #2
Timothy Loh
lgtm
6 years ago (2014-12-07 23:17:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781993002/1
6 years ago (2014-12-08 08:17:04 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-08 08:19:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186670

Powered by Google App Engine
This is Rietveld 408576698