Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
781983002:
Make clang the default on linux. (Closed)
|
Created:
6 years ago by Michael Achenbach Modified:
5 years, 11 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Project:
v8 Visibility:
Public. |
DescriptionMake clang the default on linux.
TBR=jochen@chromium.org
Committed: https://crrev.com/006b5c5cfd8517563601f331bc7a57e13bfeb202
Cr-Commit-Position: refs/heads/master@{#26164}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 20 (7 generated)
machenbach@chromium.org changed reviewers: + jochen@chromium.org
PTAL. Our mips builder has it's own compiler and overwrites CC and CXX.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781983002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781983002/1
lgtm
why not land this?
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781983002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/616)
On 2015/01/07 14:46:38, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > v8_linux_arm_rel on tryserver.v8 > (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/616) Please retry after https://codereview.chromium.org/831393006/ has landed.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781983002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/006b5c5cfd8517563601f331bc7a57e13bfeb202 Cr-Commit-Position: refs/heads/master@{#26164}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/861553004/ by jochen@chromium.org. The reason for reverting is: breaks arm and mips compilation on main waterfall. |
