Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 781953002: Allow eval in detached contexts (Closed)

Created:
6 years ago by Toon Verwaest
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Allow eval in detached contexts BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
PTAL
6 years ago (2014-12-05 12:33:05 UTC) #2
rossberg
lgtm
6 years ago (2014-12-05 12:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781953002/1
6 years ago (2014-12-05 12:58:59 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-05 13:25:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698