Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 781943002: Reland "Encode reservation meta data in the snapshot blob." (Closed)

Created:
6 years ago by Yang
Modified:
6 years ago
Reviewers:
vogelheim1, vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland "Encode reservation meta data in the snapshot blob." CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_nosnap_rel

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -601 lines) Patch
M src/mksnapshot.cc View 7 chunks +36 lines, -135 lines 0 comments Download
M src/natives-external.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/serialize.h View 9 chunks +101 lines, -95 lines 0 comments Download
M src/serialize.cc View 1 2 23 chunks +169 lines, -90 lines 0 comments Download
M src/snapshot.h View 1 chunk +1 line, -23 lines 0 comments Download
M src/snapshot-common.cc View 2 chunks +8 lines, -32 lines 0 comments Download
M src/snapshot-empty.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/snapshot-external.cc View 1 4 chunks +10 lines, -75 lines 0 comments Download
M src/snapshot-source-sink.h View 2 chunks +9 lines, -4 lines 0 comments Download
M src/snapshot-source-sink.cc View 1 3 chunks +8 lines, -15 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 9 chunks +21 lines, -108 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
Found what the issue was. Second patch set is the fix.
6 years ago (2014-12-05 11:38:58 UTC) #2
vogelheim1
lgtm
6 years ago (2014-12-05 11:42:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781943002/20001
6 years ago (2014-12-05 11:45:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1768)
6 years ago (2014-12-05 11:47:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781943002/40001
6 years ago (2014-12-05 11:55:47 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-05 13:03:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698