Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 781863004: Cleanup: Update the path to vector2d_f.h header. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
danakj, sky, samli
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tdanderson+views_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, James Su, jdduke+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Update the path to vector2d_f.h header. The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so we are updating the include paths to fix this. BUG=395370 TEST=gfx_unittests TBR=sky@chromium.org,danakj@chromium.org Committed: https://crrev.com/b486216287a3e1f30e81f70444f889d321b7819a Cr-Commit-Position: refs/heads/master@{#306960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -42 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/overscroll_glow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/android/overscroll_refresh.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/input_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/public/browser/android/synchronous_compositor_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/android/window_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/transform.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/vector2d_f.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
TBRing...
6 years ago (2014-12-05 01:16:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781863004/1
6 years ago (2014-12-05 01:17:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 02:17:25 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b486216287a3e1f30e81f70444f889d321b7819a Cr-Commit-Position: refs/heads/master@{#306960}
6 years ago (2014-12-05 02:18:12 UTC) #5
samli
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/771283003/ by samli@chromium.org. ...
6 years ago (2014-12-05 03:07:34 UTC) #6
samli
6 years ago (2014-12-05 06:38:01 UTC) #8
Message was sent while issue was closed.
This wasn't the issue. Feel free to Ireland, was unsure if this is dependent on
the other patch.

Powered by Google App Engine
This is Rietveld 408576698