Issue 78183002: Make BuildBinaryOperation use ReturnValue instead of ReturnInstruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78183002: Make BuildBinaryOperation use ReturnValue instead of ReturnInstruction. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make BuildBinaryOperation use ReturnValue instead of ReturnInstruction. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17914

Patch Set 2 : Add comment. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -50 lines)			Patch
M	src/code-stubs-hydrogen.cc	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	src/hydrogen.h	View		2 chunks	+11 lines, -11 lines	0 comments	Download
M	src/hydrogen.cc	View	1	7 chunks	+34 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc#newcode8585 src/hydrogen.cc:8585: if (result->HasObservableSideEffects() || result->IsPhi()) { ...

7 years, 1 month ago (2013-11-20 11:44:47 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc#newcode8585 src/hydrogen.cc:8585: if (result->HasObservableSideEffects() || result->IsPhi()) { On 2013/11/20 11:44:48, Sven ...

7 years, 1 month ago (2013-11-20 12:00:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17914.

Expand Messages | Collapse Messages

Issue 78183002: Make BuildBinaryOperation use ReturnValue instead of ReturnInstruction. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add comment. #

Messages