Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 781823002: Add CompositeMachMessageServer and its test (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add CompositeMachMessageServer and its test. TEST=util_test CompositeMachMessageServer* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c83e773c331c0555d62bae855fc438244586dcba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, -8 lines) Patch
M util/mach/child_port_server.h View 1 chunk +2 lines, -0 lines 0 comments Download
M util/mach/child_port_server.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M util/mach/child_port_server_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A util/mach/composite_mach_message_server.h View 1 chunk +103 lines, -0 lines 0 comments Download
A util/mach/composite_mach_message_server.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A util/mach/composite_mach_message_server_test.cc View 1 chunk +303 lines, -0 lines 0 comments Download
M util/mach/exc_server_variants.h View 4 chunks +8 lines, -0 lines 0 comments Download
M util/mach/exc_server_variants.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 8 chunks +46 lines, -0 lines 0 comments Download
M util/mach/mach_message_server.h View 2 chunks +6 lines, -0 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 7 chunks +16 lines, -8 lines 0 comments Download
M util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-04 18:59:24 UTC) #2
Robert Sesek
LGTM. Nifty.
6 years ago (2014-12-04 21:39:52 UTC) #3
Mark Mentovai
6 years ago (2014-12-04 21:45:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c83e773c331c0555d62bae855fc438244586dcba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698