Roll Clang 218707:223109 (+r223211, +r223219, -r220714)

Roll Clang 218707:223109 (+r223211, +r223219, -r220714)

Perf sheriffs: we're expecting a ~350 KiB size regression
for this. Expectations need to be updated.

BUG=431803
TBR=brettw
NOTRY=true

Committed: https://crrev.com/dcc1f6bc8b1b5ab295cd0888db37b0e7c0749eb0
Cr-Commit-Position: refs/heads/master@{#307492}

[hans, 2014-12-08 23:01:59]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2014-12-08 23:02:12]

Please take a look.

[hans, 2014-12-08 23:03:08]

The mac_asan_64 and linux_chromeos_asan test failures correspond with failures
on a whitespace change: https://codereview.chromium.org/405473002

[Nico, 2014-12-08 23:13:58]

lgtm

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
File chrome/installer/linux/rpm/expected_deps_i386 (right):

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
chrome/installer/linux/rpm/expected_deps_i386:29: libgcc_s.so.1(GCC_4.0.0)
Do you know why this is back?

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:402: # Revert r220714: "Frontend: Define
__EXCEPTIONS if -fexceptions is passed"
This is pretty sketchy, but looking the other way since we haven't rolled in way
too long.

(i think we decided to keep this one in and fix breakpad instead)

[hans, 2014-12-08 23:19:51]

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
File chrome/installer/linux/rpm/expected_deps_i386 (right):

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
chrome/installer/linux/rpm/expected_deps_i386:29: libgcc_s.so.1(GCC_4.0.0)
On 2014/12/08 23:13:58, Nico wrote:
> Do you know why this is back?

Yes, it's for __divdc3 and __muldc3, which I believe is due to Clang r220714.

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:402: # Revert r220714: "Frontend: Define
__EXCEPTIONS if -fexceptions is passed"
On 2014/12/08 23:13:58, Nico wrote:
> This is pretty sketchy, but looking the other way since we haven't rolled in
way
> too long.

Right.


> (i think we decided to keep this one in and fix breakpad instead)

OK. Will we need changes for the -f flag business too?

[hans, 2014-12-08 23:20:44]

On 2014/12/08 23:19:51, hans wrote:
> > Do you know why this is back?
> 
> Yes, it's for __divdc3 and __muldc3, which I believe is due to Clang r220714.

Err, copy-paste fail. I mean due to r219557.

[hans, 2014-12-08 23:20:57]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-12-08 23:22:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/781763003/100001

[commit-bot: I haz the power, 2014-12-08 23:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-08 23:26:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2014-12-08 23:31:15]

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
File chrome/installer/linux/rpm/expected_deps_i386 (right):

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
chrome/installer/linux/rpm/expected_deps_i386:29: libgcc_s.so.1(GCC_4.0.0)
On 2014/12/08 23:19:51, hans wrote:
> On 2014/12/08 23:13:58, Nico wrote:
> > Do you know why this is back?
> 
> Yes, it's for __divdc3 and __muldc3, which I believe is due to Clang r221821.

Hm, that cl message claims to fix fallout from r219557 which we yet don't have
either? But looks like the right area, thanks for checking.

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:402: # Revert r220714: "Frontend: Define
__EXCEPTIONS if -fexceptions is passed"
On 2014/12/08 23:19:51, hans wrote:
> On 2014/12/08 23:13:58, Nico wrote:
> > This is pretty sketchy, but looking the other way since we haven't rolled in
> way
> > too long.
> 
> Right.
> 
> 
> > (i think we decided to keep this one in and fix breakpad instead)
> 
> OK. Will we need changes for the -f flag business too?

No, David and Richard talked about this for a long time today, and the final
decision was that David's going to revert r223455. This rolls to before that
change, and the next roll hopefully will have both r223455 and its revert.

[hans, 2014-12-08 23:45:49]

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
File chrome/installer/linux/rpm/expected_deps_i386 (right):

https://codereview.chromium.org/781763003/diff/100001/chrome/installer/linux/...
chrome/installer/linux/rpm/expected_deps_i386:29: libgcc_s.so.1(GCC_4.0.0)
On 2014/12/08 23:31:15, Nico wrote:
> On 2014/12/08 23:19:51, hans wrote:
> > On 2014/12/08 23:13:58, Nico wrote:
> > > Do you know why this is back?
> > 
> > Yes, it's for __divdc3 and __muldc3, which I believe is due to Clang
r221821.
> 
> Hm, that cl message claims to fix fallout from r219557 which we yet don't have
> either? But looks like the right area, thanks for checking.

r219557 is the one I meant (see my follow-up email). I think that's the one.

[Nico, 2014-12-09 00:33:33]

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/781763003/diff/100001/tools/clang/scripts/upd...
tools/clang/scripts/update.sh:402: # Revert r220714: "Frontend: Define
__EXCEPTIONS if -fexceptions is passed"
On 2014/12/08 23:31:15, Nico wrote:
> On 2014/12/08 23:19:51, hans wrote:
> > On 2014/12/08 23:13:58, Nico wrote:
> > > This is pretty sketchy, but looking the other way since we haven't rolled
in
> > way
> > > too long.
> > 
> > Right.
> > 
> > 
> > > (i think we decided to keep this one in and fix breakpad instead)
> > 
> > OK. Will we need changes for the -f flag business too?
> 
> No, David and Richard talked about this for a long time today, and the final
> decision was that David's going to revert r223455. This rolls to before that
> change, and the next roll hopefully will have both r223455 and its revert.

The revert happened in r223723.

[hans, 2014-12-09 15:32:55]

hans@chromium.org changed reviewers:
+ brettw@chromium.org, phajdan.jr@chromium.org

[hans, 2014-12-09 15:32:55]

+phajdan.jr for chrome/installer/linux/
+brettw for the .gn file

[hans, 2014-12-09 15:33:08]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-12-09 15:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/781763003/120001

[commit-bot: I haz the power, 2014-12-09 15:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-09 15:37:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Paweł Hajdan Jr., 2014-12-09 16:41:03]

chrome/installer/linux LGTM

[hans, 2014-12-09 17:20:36]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2014-12-09 17:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/781763003/120001

[commit-bot: I haz the power, 2014-12-09 17:22:55]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-12-09 17:24:04]

Patchset 7 (id:??) landed as
https://crrev.com/dcc1f6bc8b1b5ab295cd0888db37b0e7c0749eb0
Cr-Commit-Position: refs/heads/master@{#307492}