Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 781753005: Pointer/hover media query support: platform-dependent changes #2 (Closed)

Created:
6 years ago by mustaq
Modified:
6 years ago
Reviewers:
sadrul, Rick Byers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pointer/hover media query support: platform-dependent changes #2 This is the second platform-dependent CL on our way to support pointer, any-pointer, hover and any-hover media queries. http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction This CL includes changes for windows, aurax11, linux and ozone. This follows the platform-independent patch (crrev.com/685153003) and the Android-specific patch (crrev.com/696713002). BUG=136119 Committed: https://crrev.com/501df9f345e2c479d91146be1af2b9a4887b9e67 Cr-Commit-Position: refs/heads/master@{#307983}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : Completed aurax11 #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -28 lines) Patch
M ui/base/touch/touch_device.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/base/touch/touch_device_aurax11.cc View 1 2 3 4 2 chunks +42 lines, -6 lines 0 comments Download
M ui/base/touch/touch_device_ozone.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/base/touch/touch_device_win.cc View 1 2 2 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mustaq
ptal
6 years ago (2014-12-05 17:05:02 UTC) #2
sadrul
https://codereview.chromium.org/781753005/diff/40001/ui/base/touch/touch_device_aurax11.cc File ui/base/touch/touch_device_aurax11.cc (right): https://codereview.chromium.org/781753005/diff/40001/ui/base/touch/touch_device_aurax11.cc#newcode20 ui/base/touch/touch_device_aurax11.cc:20: return POINTER_TYPE_COARSE | POINTER_TYPE_NONE; Should this look at IsTouchDevicePresent() ...
6 years ago (2014-12-07 17:46:19 UTC) #3
mustaq
ptal https://codereview.chromium.org/781753005/diff/40001/ui/base/touch/touch_device_aurax11.cc File ui/base/touch/touch_device_aurax11.cc (right): https://codereview.chromium.org/781753005/diff/40001/ui/base/touch/touch_device_aurax11.cc#newcode20 ui/base/touch/touch_device_aurax11.cc:20: return POINTER_TYPE_COARSE | POINTER_TYPE_NONE; On 2014/12/07 17:46:18, sadrul ...
6 years ago (2014-12-09 20:46:19 UTC) #4
sadrul
LGTM https://codereview.chromium.org/781753005/diff/60001/ui/base/touch/touch_device_aurax11.cc File ui/base/touch/touch_device_aurax11.cc (right): https://codereview.chromium.org/781753005/diff/60001/ui/base/touch/touch_device_aurax11.cc#newcode22 ui/base/touch/touch_device_aurax11.cc:22: int available_pointer_types = POINTER_TYPE_NONE; You can look for ...
6 years ago (2014-12-11 15:22:27 UTC) #6
mustaq
https://codereview.chromium.org/781753005/diff/60001/ui/base/touch/touch_device_aurax11.cc File ui/base/touch/touch_device_aurax11.cc (right): https://codereview.chromium.org/781753005/diff/60001/ui/base/touch/touch_device_aurax11.cc#newcode22 ui/base/touch/touch_device_aurax11.cc:22: int available_pointer_types = POINTER_TYPE_NONE; On 2014/12/11 15:22:27, sadrul (OOO ...
6 years ago (2014-12-11 19:21:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781753005/100001
6 years ago (2014-12-11 19:29:46 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-11 23:08:55 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/501df9f345e2c479d91146be1af2b9a4887b9e67
Cr-Commit-Position: refs/heads/master@{#307983}

Powered by Google App Engine
This is Rietveld 408576698