Replace hints. Resolve TODO.

pkg/analyzer/lib/src/generated/incremental_resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'ast.dart';
@@ skipping 711 matching lines @@
   /**
    * Return `true` if the portion of the element model defined by the given node
    * has changed.
    *
    * [node] - the node defining the portion of the element model being tested.
    *
    * Throws [AnalysisException] if the correctness of the element model cannot
    * be determined.
    */
   bool _elementModelChanged(AstNode node) {
-    // If we are replacing the whole declaration (e.g. rename a parameter), we
-    // can try to find the corresponding Element in the enclosing one, see if it
-    // is compatible, and if 'yes', then restore and update it.
-    // TODO(scheglov) This should be rewritten. It causes validating the whole
-    // class, when just one method is changed.
+    // If we are replacing the whole declaration, this means that its signature
+    // is changed. It might be an API change, or not.
+    //
+    // If a required parameter is change, it is not an API change, but we want

[Brian Wilkerson, 2014/12/04 14:45:22]

"change" --> "changed"

+    // to find the existing corresponding Element in the enclosing one,
+    // set it for the node and update as needed.
+    //
+    // If, for example, the name of a method is changed, it is an API change,
+    // we need to know the old Element and the new Element. Again, we need to
+    // check the whole enclosing Element.
     if (node is Declaration) {
       node = node.parent;
     }
     Element element = _getElement(node);
     if (element == null) {
       throw new AnalysisException(
           "Cannot resolve node: a ${node.runtimeType} does not define an element");
     }
     DeclarationMatcher matcher = new DeclarationMatcher();
     return !matcher.matches(node, element);
@@ skipping 430 matching lines @@
     }
     {
       List<AnalysisError> oldErrors =
           _entry.getValueInLibrary(DartEntry.VERIFICATION_ERRORS, _librarySource);
       List<AnalysisError> errors = _updateErrors(oldErrors, _newVerifyErrors);
       _entry.setValueInLibrary(
           DartEntry.VERIFICATION_ERRORS,
           _librarySource,
           errors);
     }
-    {
-      List<AnalysisError> oldErrors =
-          _entry.getValueInLibrary(DartEntry.HINTS, _librarySource);
-      List<AnalysisError> errors = _updateErrors(oldErrors, _newHints);
-      _entry.setValueInLibrary(DartEntry.HINTS, _librarySource, errors);
-    }
+    _entry.setValueInLibrary(DartEntry.HINTS, _librarySource, _newHints);
   }
 
   List<AnalysisError> _updateErrors(List<AnalysisError> oldErrors,
       List<AnalysisError> newErrors) {
     List<AnalysisError> errors = new List<AnalysisError>();
     // add updated old errors
     for (AnalysisError error in oldErrors) {
       int errorOffset = error.offset;
       if (errorOffset < _updateOffset) {
         errors.add(error);
@@ skipping 453 matching lines @@
   String toString() => name;
 }
 
 
 class _TokenPair {
   final _TokenDifferenceKind kind;
   final Token oldToken;
   final Token newToken;
   _TokenPair(this.kind, this.oldToken, this.newToken);
 }