Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 781673002: Use C++11 range-based loop for core/xml and core/loader (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
5 years, 11 months ago
Reviewers:
Nate Chapin, rwlbuis
CC:
blink-reviews, kenneth.christiansen, Rik, webcomponents-bugzilla_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, aandrey+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use C++11 range-based loop for core/xml and core/loader BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188021

Patch Set 1 : change for in xml #

Patch Set 2 : use auto #

Patch Set 3 : code style fix #

Patch Set 4 : change variable name #

Patch Set 5 : rebase #

Total comments: 4

Patch Set 6 : remove unnecessary curly brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -44 lines) Patch
M Source/core/loader/CrossOriginPreflightResultCache.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 2 3 4 5 2 chunks +5 lines, -8 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 2 3 4 5 1 chunk +4 lines, -7 lines 0 comments Download
M Source/core/xml/XPathNodeSet.cpp View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/xml/XPathStep.cpp View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 3 4 5 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
zhaoze.zhou
6 years ago (2014-12-10 22:07:00 UTC) #2
philipj_slow
Have you done this conversion with a tool? clang-modernize should be able to do it. ...
6 years ago (2014-12-10 22:51:43 UTC) #6
zhaoze.zhou
On 2014/12/10 22:51:43, philipj wrote: > Have you done this conversion with a tool? clang-modernize ...
6 years ago (2014-12-11 02:49:47 UTC) #7
zhaoze.zhou
PTAL. thanks.
6 years ago (2014-12-11 23:21:21 UTC) #9
zhaoze.zhou
PTAL. thanks.
6 years ago (2014-12-11 23:21:22 UTC) #10
zhaoze.zhou
On 2014/12/11 23:21:22, zhaoze.zhou wrote: > PTAL. thanks. webkit has similar patches. i.e. http://trac.webkit.org/changeset/173422 @japhet ...
6 years ago (2014-12-18 21:40:17 UTC) #11
Nate Chapin
LGTM w/nits https://codereview.chromium.org/781673002/diff/140001/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (right): https://codereview.chromium.org/781673002/diff/140001/Source/core/loader/DocumentThreadableLoader.cpp#newcode331 Source/core/loader/DocumentThreadableLoader.cpp:331: for (const auto& header : m_simpleRequestHeaders) { ...
5 years, 11 months ago (2015-01-05 21:41:04 UTC) #12
zhaoze.zhou
https://codereview.chromium.org/781673002/diff/140001/Source/core/loader/DocumentThreadableLoader.cpp File Source/core/loader/DocumentThreadableLoader.cpp (right): https://codereview.chromium.org/781673002/diff/140001/Source/core/loader/DocumentThreadableLoader.cpp#newcode331 Source/core/loader/DocumentThreadableLoader.cpp:331: for (const auto& header : m_simpleRequestHeaders) { On 2015/01/05 ...
5 years, 11 months ago (2015-01-08 03:18:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781673002/160001
5 years, 11 months ago (2015-01-08 03:20:02 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 03:23:15 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188021

Powered by Google App Engine
This is Rietveld 408576698