Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 781623002: [NaCl SDK] Messaging example (demonstrates postMessageAndAwaitResponse) (Closed)

Created:
6 years ago by binji
Modified:
6 years ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Messaging example (demonstrates postMessageAndAwaitResponse) BUG=none R=sbc@chromium.org Committed: https://crrev.com/74be87a0ec9dbfcd7ee9021e68ec2ce4cda442e7 Cr-Commit-Position: refs/heads/master@{#307048}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -4 lines) Patch
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/test_projects.py View 1 chunk +4 lines, -0 lines 0 comments Download
A + native_client_sdk/src/examples/api/messaging/example.dsc View 2 chunks +4 lines, -4 lines 0 comments Download
A native_client_sdk/src/examples/api/messaging/example.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/api/messaging/index.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/api/messaging/messaging.cc View 1 1 chunk +96 lines, -0 lines 0 comments Download
A native_client_sdk/src/examples/api/messaging/test.js View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
binji
6 years ago (2014-12-03 23:02:55 UTC) #1
binji
+dmichael
6 years ago (2014-12-03 23:22:50 UTC) #3
dmichael (off chromium)
lgtm https://codereview.chromium.org/781623002/diff/1/native_client_sdk/src/examples/api/messaging/example.js File native_client_sdk/src/examples/api/messaging/example.js (right): https://codereview.chromium.org/781623002/diff/1/native_client_sdk/src/examples/api/messaging/example.js#newcode7 native_client_sdk/src/examples/api/messaging/example.js:7: } I wouldn't define $ in an example... ...
6 years ago (2014-12-03 23:33:33 UTC) #4
binji
https://codereview.chromium.org/781623002/diff/1/native_client_sdk/src/examples/api/messaging/example.js File native_client_sdk/src/examples/api/messaging/example.js (right): https://codereview.chromium.org/781623002/diff/1/native_client_sdk/src/examples/api/messaging/example.js#newcode7 native_client_sdk/src/examples/api/messaging/example.js:7: } On 2014/12/03 23:33:33, dmichael wrote: > I wouldn't ...
6 years ago (2014-12-03 23:56:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781623002/20001
6 years ago (2014-12-05 18:22:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-05 18:29:17 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-05 18:30:07 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/74be87a0ec9dbfcd7ee9021e68ec2ce4cda442e7
Cr-Commit-Position: refs/heads/master@{#307048}

Powered by Google App Engine
This is Rietveld 408576698