Issue 781603002: Port even more FocusController tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 781603002: Port even more FocusController tests. (Closed)

Created:
6 years ago by Elliot Glaysher

Modified:
6 years ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Port even more FocusController tests. This modifies how the test harness works so that we have a tree of pointer so we can Destroy() part of it during one of the tests. BUG=431047 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/800ca44eb769f1a4ce01ebb95157eb8d74367bcb

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+433 lines, -56 lines)			Patch
M	services/window_manager/focus_controller.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	services/window_manager/focus_controller_unittest.cc	View	1 2 3	21 chunks	+417 lines, -55 lines	0 comments	Download
M	services/window_manager/window_manager_test_util.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	services/window_manager/window_manager_test_util.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Elliot Glaysher

I did an asan build locally to make sure the allocation stuff here was clean.

6 years ago (2014-12-03 21:48:52 UTC) #2

Elliot Glaysher

6 years ago (2014-12-03 23:30:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
800ca44eb769f1a4ce01ebb95157eb8d74367bcb (presubmit successful).