Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 781593003: MachMessageServer: add some DCHECKs (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

MachMessageServer: add some DCHECKs. These DCHECKs make sure that buffer sizes and message sizes are as expected. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9f520e3fbfa39552228926480f113ab8a3731db8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M util/mach/mach_message_server.cc View 4 chunks +18 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-03 21:49:31 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-03 23:16:08 UTC) #3
Mark Mentovai
6 years ago (2014-12-03 23:21:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9f520e3fbfa39552228926480f113ab8a3731db8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698