Issue 781583003: Timeline: prepare to using frame viewer instrumentation event, ignore AnalyzeTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 781583003: Timeline: prepare to using frame viewer instrumentation event, ignore AnalyzeTask (Closed)

Created:
6 years ago by caseq

Modified:
6 years ago

Reviewers:
alph, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Timeline: prepare to using frame viewer instrumentation event, ignore AnalyzeTask Once we add disabled-by-default-devtools.timeline category to frame_viewer_instrumentation in cc, we'll be getting AnalyzeTask event that we don't want to display for the moment. BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineModel.js	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

alph

https://codereview.chromium.org/781583003/diff/1/Source/devtools/front_end/timeline/TimelineModel.js File Source/devtools/front_end/timeline/TimelineModel.js (right): https://codereview.chromium.org/781583003/diff/1/Source/devtools/front_end/timeline/TimelineModel.js#newcode74 Source/devtools/front_end/timeline/TimelineModel.js:74: AnalyzeTask: "AnalyzeTask", Don't we just skip unknown event types ...

6 years ago (2014-12-08 15:36:02 UTC) #4

Ouch, indeed, I forgot that :( Closing this one, please disregard.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages