Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 781573002: [Android] Add a gtest test instance for the test runner's platform mode. (Closed)

Created:
6 years ago by jbudorick
Modified:
6 years ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a gtest test instance for the test runner's platform mode. BUG=428729 Committed: https://crrev.com/27e6905fcad4761514b1ee5d2e641c9cb6467dd5 Cr-Commit-Position: refs/heads/master@{#306709}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -3 lines) Patch
M build/android/pylib/base/test_instance_factory.py View 1 chunk +10 lines, -3 lines 0 comments Download
A build/android/pylib/gtest/gtest_test_instance.py View 1 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
6 years ago (2014-12-03 21:02:23 UTC) #2
klundberg
https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py#newcode18 build/android/pylib/gtest/gtest_test_instance.py:18: _DEPS_EXCLUSION_LIST = [ I'm assuming this is something from ...
6 years ago (2014-12-03 21:22:45 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py#newcode126 build/android/pylib/gtest/gtest_test_instance.py:126: In the DD you mention "def GetApkUnderTest(self):" Is this ...
6 years ago (2014-12-03 21:28:37 UTC) #4
jbudorick
https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py File build/android/pylib/gtest/gtest_test_instance.py (right): https://codereview.chromium.org/781573002/diff/1/build/android/pylib/gtest/gtest_test_instance.py#newcode18 build/android/pylib/gtest/gtest_test_instance.py:18: _DEPS_EXCLUSION_LIST = [ On 2014/12/03 21:22:45, klundberg wrote: > ...
6 years ago (2014-12-03 21:42:43 UTC) #5
klundberg
lgtm
6 years ago (2014-12-03 21:45:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781573002/20001
6 years ago (2014-12-03 22:08:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 23:27:56 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-03 23:30:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27e6905fcad4761514b1ee5d2e641c9cb6467dd5
Cr-Commit-Position: refs/heads/master@{#306709}

Powered by Google App Engine
This is Rietveld 408576698