depot_tools: Send the remote tracked ref to Rietveld via upload.py

third_party/upload.py

Index: third_party/upload.py
===================================================================
--- third_party/upload.py	(revision 293289)
+++ third_party/upload.py	(working copy)
@@ -650,6 +650,10 @@
                  help="Base URL path for files (listed as \"Base URL\" when "
                  "viewing issue).  If omitted, will be guessed automatically "
                  "for SVN repos and left blank for others.")
+group.add_option("--target_ref", action="store", dest="target_ref",

[agable, 2014/12/09 20:42:56]

Make sure that this change gets landed in Rietveld's upload.py (in infra.git)
first, and then gets downstreamed to here.

[rmistry, 2014/12/09 20:54:43]

I am glad you brought this up.
Could you explain how this works? is this a copy of
https://chromium.googlesource.com/infra/infra/+/master/appengine/chromium_rie...
or is it brought here by some DEPS (which I could not find).

Do I need to make a change to
https://chromium.googlesource.com/infra/infra/+/master/appengine/chromium_rie...
and to depot_tools/third_party/upload.py ?

[agable, 2014/12/09 23:36:33]

It is a copy of the one in chromium_rietveld. The procedure is
1) Figure out the change you want to land in depot_tools
2) Land it in infra.git
3) Land it in depot_tools

It used to be more important, when Rietveld lived in its own repo and we didn't
100% control it. We had to land changes there first and then downstream them to
us. Now, I think the order matters less. But we do have to make sure the same
changes land in both.

+                 default=None,
+                 help="The target ref that is transitively tracked by the "
+                 "local branch this patch comes from.")
 group.add_option("--download_base", action="store_true",
                  dest="download_base", default=False,
                  help="Base files will be downloaded by the server "
@@ -2605,6 +2609,8 @@
     form_fields.append(("cc", options.cc))
   if options.project:
     form_fields.append(("project", options.project))
+  if options.target_ref:
+    form_fields.append(("target_ref", options.target_ref))
 
   # Process --message, --title and --file.
   message = options.message or ""