Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 781443004: Clean up tests to use reportPromise. (Closed)

Created:
6 years ago by Ben Kwa
Modified:
6 years ago
Reviewers:
kenobi, hirono
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up tests to use reportPromise. BUG=None Committed: https://crrev.com/50ef4ac03aaa59b95c14349eec57326e8202501a Cr-Commit-Position: refs/heads/master@{#307031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -113 lines) Patch
M chrome/test/data/file_manager/unit_tests/media_scanner_unittest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/file_manager/unit_tests/media_scanner_unittest.js View 4 chunks +95 lines, -112 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Kwa
6 years ago (2014-12-04 23:30:02 UTC) #2
hirono
Thanks! lgtm!
6 years ago (2014-12-05 02:21:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781443004/1
6 years ago (2014-12-05 15:14:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 16:17:28 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-05 16:18:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50ef4ac03aaa59b95c14349eec57326e8202501a
Cr-Commit-Position: refs/heads/master@{#307031}

Powered by Google App Engine
This is Rietveld 408576698