Issue 781203003: Handle invalid parser cache gracefully (move invalid cache handling to embedder).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 781203003: Handle invalid parser cache gracefully (move invalid cache handling to embedder). (Closed)

Created:
6 years ago by marja

Modified:
6 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

Handle invalid parser cache gracefully (move invalid cache handling to embedder). Blink already has code for handling invalid cached data. The attached test ensures that cached data is gracefully rejected if it cannot be used. This also unifies parser cache and code cache handling. R=yangguo@chromium.org BUG=439889 LOG=N

Patch Set 1 #

Patch Set 2 : streaminglining the test #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -51 lines)			Patch
M	src/parser.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/parser.cc	View		1 chunk	+51 lines, -51 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	2 chunks	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yang

On 2014/12/08 10:39:09, marja wrote: > yangguo, ptal at this crash mitigation cl lgtm.

6 years ago (2014-12-08 11:13:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/781203003/20001

6 years ago (2014-12-08 11:21:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages