Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/effects/SkGpuBlurUtils.cpp

Issue 781153002: Fix Morphology effects sourcing outside of the crop rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkGpuBlurUtils.cpp
diff --git a/src/effects/SkGpuBlurUtils.cpp b/src/effects/SkGpuBlurUtils.cpp
index 23128e0ccabb83ecac6df0d3ed6844a0ebda2e3d..228555bf4a9ed1807c5b6ad908edb1a4e53c0094 100644
--- a/src/effects/SkGpuBlurUtils.cpp
+++ b/src/effects/SkGpuBlurUtils.cpp
@@ -56,7 +56,6 @@ static void convolve_gaussian_1d(GrContext* context,
paint.reset();
SkAutoTUnref<GrFragmentProcessor> conv(GrConvolutionEffect::CreateGaussian(
texture, direction, radius, sigma, useBounds, bounds));
- paint.reset();
Justin Novosad 2014/12/22 20:11:11 This seems unrelated. Should go in a separate CL.
cwallez 2015/01/19 21:34:38 Done.
paint.addColorProcessor(conv);
context->drawRectToRect(paint, dstRect, srcRect);
}
@@ -79,7 +78,6 @@ static void convolve_gaussian_2d(GrContext* context,
texture, bounds, size, 1.0, 0.0, kernelOffset,
useBounds ? GrTextureDomain::kClamp_Mode : GrTextureDomain::kIgnore_Mode,
true, sigmaX, sigmaY));
- paint.reset();
paint.addColorProcessor(conv);
context->drawRectToRect(paint, dstRect, srcRect);
}

Powered by Google App Engine
This is Rietveld 408576698