Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Side by Side Diff: gm/imagefilterscropped.cpp

Issue 781153002: Fix Morphology effects sourcing outside of the crop rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix memory leak and shader compilation error on MacOSX 10.6 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/effects/SkMorphologyImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 #include "SkCanvas.h" 9 #include "SkCanvas.h"
10 #include "SkColorFilter.h" 10 #include "SkColorFilter.h"
11 #include "SkColorPriv.h" 11 #include "SkColorPriv.h"
12 #include "SkShader.h" 12 #include "SkShader.h"
13 13
14 #include "SkBlurImageFilter.h" 14 #include "SkBlurImageFilter.h"
15 #include "SkMorphologyImageFilter.h"
15 #include "SkColorFilterImageFilter.h" 16 #include "SkColorFilterImageFilter.h"
17 #include "SkBitmapSource.h"
16 #include "SkMergeImageFilter.h" 18 #include "SkMergeImageFilter.h"
17 #include "SkOffsetImageFilter.h" 19 #include "SkOffsetImageFilter.h"
18 #include "SkTestImageFilters.h" 20 #include "SkTestImageFilters.h"
19 21
20 /////////////////////////////////////////////////////////////////////////////// 22 ///////////////////////////////////////////////////////////////////////////////
21 23
22 static void draw_paint(SkCanvas* canvas, const SkRect& r, SkImageFilter* imf) { 24 static void draw_paint(SkCanvas* canvas, const SkRect& r, SkImageFilter* imf) {
23 SkPaint paint; 25 SkPaint paint;
24 paint.setImageFilter(imf); 26 paint.setImageFilter(imf);
25 paint.setColor(SK_ColorBLACK); 27 paint.setColor(SK_ColorBLACK);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 93
92 class ImageFiltersCroppedGM : public skiagm::GM { 94 class ImageFiltersCroppedGM : public skiagm::GM {
93 public: 95 public:
94 ImageFiltersCroppedGM () {} 96 ImageFiltersCroppedGM () {}
95 97
96 protected: 98 protected:
97 virtual SkString onShortName() { 99 virtual SkString onShortName() {
98 return SkString("imagefilterscropped"); 100 return SkString("imagefilterscropped");
99 } 101 }
100 102
101 virtual SkISize onISize() { return SkISize::Make(400, 640); } 103 virtual SkISize onISize() { return SkISize::Make(400, 880); }
104
105 void make_checkerboard() {
106 fCheckerboard.allocN32Pixels(80, 80);
107 SkCanvas canvas(fCheckerboard);
108 canvas.clear(SK_ColorTRANSPARENT);
109 SkPaint darkPaint;
110 darkPaint.setColor(0xFF404040);
111 SkPaint lightPaint;
112 lightPaint.setColor(0xFFA0A0A0);
113 for (int y = 0; y < 80; y += 16) {
114 for (int x = 0; x < 80; x += 16) {
115 canvas.save();
116 canvas.translate(SkIntToScalar(x), SkIntToScalar(y));
117 canvas.drawRect(SkRect::MakeXYWH(0, 0, 8, 8), darkPaint);
118 canvas.drawRect(SkRect::MakeXYWH(8, 0, 8, 8), lightPaint);
119 canvas.drawRect(SkRect::MakeXYWH(0, 8, 8, 8), lightPaint);
120 canvas.drawRect(SkRect::MakeXYWH(8, 8, 8, 8), darkPaint);
121 canvas.restore();
122 }
123 }
124 }
102 125
103 void draw_frame(SkCanvas* canvas, const SkRect& r) { 126 void draw_frame(SkCanvas* canvas, const SkRect& r) {
104 SkPaint paint; 127 SkPaint paint;
105 paint.setStyle(SkPaint::kStroke_Style); 128 paint.setStyle(SkPaint::kStroke_Style);
106 paint.setColor(SK_ColorRED); 129 paint.setColor(SK_ColorRED);
107 canvas->drawRect(r, paint); 130 canvas->drawRect(r, paint);
108 } 131 }
109 132
133 virtual void onOnceBeforeDraw() SK_OVERRIDE{
134 make_checkerboard();
135 }
136
110 virtual void onDraw(SkCanvas* canvas) { 137 virtual void onDraw(SkCanvas* canvas) {
111 void (*drawProc[])(SkCanvas*, const SkRect&, SkImageFilter*) = { 138 void (*drawProc[])(SkCanvas*, const SkRect&, SkImageFilter*) = {
112 draw_sprite, draw_bitmap, draw_path, draw_paint, draw_text 139 draw_sprite, draw_bitmap, draw_path, draw_paint, draw_text
113 }; 140 };
114 141
115 SkAutoTUnref<SkColorFilter> cf( 142 SkAutoTUnref<SkColorFilter> cf(
116 SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mod e)); 143 SkColorFilter::CreateModeFilter(SK_ColorBLUE, SkXfermode::kSrcIn_Mod e));
117 SkImageFilter::CropRect cropRect(SkRect::Make(SkIRect::MakeXYWH(10, 10, 44, 44)), SkImageFilter::CropRect::kHasAll_CropEdge); 144 SkImageFilter::CropRect cropRect(SkRect::Make(SkIRect::MakeXYWH(10, 10, 44, 44)), SkImageFilter::CropRect::kHasAll_CropEdge);
118 SkImageFilter::CropRect bogusRect(SkRect::Make(SkIRect::MakeXYWH(-100, - 100, 10, 10)), SkImageFilter::CropRect::kHasAll_CropEdge); 145 SkImageFilter::CropRect bogusRect(SkRect::Make(SkIRect::MakeXYWH(-100, - 100, 10, 10)), SkImageFilter::CropRect::kHasAll_CropEdge);
119 146
120 SkAutoTUnref<SkImageFilter> offset(SkOffsetImageFilter::Create( 147 SkAutoTUnref<SkImageFilter> offset(SkOffsetImageFilter::Create(
121 SkIntToScalar(-10), SkIntToScalar(-10))); 148 SkIntToScalar(-10), SkIntToScalar(-10)));
122 149
123 SkAutoTUnref<SkImageFilter> cfOffset(SkColorFilterImageFilter::Create(cf .get(), offset.get())); 150 SkAutoTUnref<SkImageFilter> cfOffset(SkColorFilterImageFilter::Create(cf .get(), offset.get()));
124 151
152 SkAutoTUnref<SkImageFilter> erodeX(SkErodeImageFilter::Create(8, 0, NULL , &cropRect));
153 SkAutoTUnref<SkImageFilter> erodeY(SkErodeImageFilter::Create(0, 8, NULL , &cropRect));
154
125 SkImageFilter* filters[] = { 155 SkImageFilter* filters[] = {
126 NULL, 156 NULL,
127 SkColorFilterImageFilter::Create(cf.get(), NULL, &cropRect), 157 SkColorFilterImageFilter::Create(cf.get(), NULL, &cropRect),
128 SkBlurImageFilter::Create(1.0f, 1.0f, NULL, &cropRect), 158 SkBlurImageFilter::Create(1.0f, 1.0f, NULL, &cropRect),
129 SkBlurImageFilter::Create(8.0f, 0.0f, NULL, &cropRect), 159 SkBlurImageFilter::Create(8.0f, 0.0f, NULL, &cropRect),
130 SkBlurImageFilter::Create(0.0f, 8.0f, NULL, &cropRect), 160 SkBlurImageFilter::Create(0.0f, 8.0f, NULL, &cropRect),
131 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &cropRect), 161 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &cropRect),
162 SkErodeImageFilter::Create(1, 1, NULL, &cropRect),
163 SkErodeImageFilter::Create(8, 0, erodeY, &cropRect),
164 SkErodeImageFilter::Create(0, 8, erodeX, &cropRect),
165 SkErodeImageFilter::Create(8, 8, NULL, &cropRect),
132 SkMergeImageFilter::Create(NULL, cfOffset.get(), SkXfermode::kSrcOve r_Mode, &cropRect), 166 SkMergeImageFilter::Create(NULL, cfOffset.get(), SkXfermode::kSrcOve r_Mode, &cropRect),
133 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &bogusRect), 167 SkBlurImageFilter::Create(8.0f, 8.0f, NULL, &bogusRect),
134 SkColorFilterImageFilter::Create(cf.get(), NULL, &bogusRect), 168 SkColorFilterImageFilter::Create(cf.get(), NULL, &bogusRect),
135 }; 169 };
136 170
137 SkRect r = SkRect::MakeWH(SkIntToScalar(64), SkIntToScalar(64)); 171 SkRect r = SkRect::MakeWH(SkIntToScalar(64), SkIntToScalar(64));
138 SkScalar MARGIN = SkIntToScalar(16); 172 SkScalar MARGIN = SkIntToScalar(16);
139 SkScalar DX = r.width() + MARGIN; 173 SkScalar DX = r.width() + MARGIN;
140 SkScalar DY = r.height() + MARGIN; 174 SkScalar DY = r.height() + MARGIN;
141 175
142 canvas->translate(MARGIN, MARGIN); 176 canvas->translate(MARGIN, MARGIN);
143 for (size_t j = 0; j < SK_ARRAY_COUNT(drawProc); ++j) { 177 for (size_t j = 0; j < SK_ARRAY_COUNT(drawProc); ++j) {
144 canvas->save(); 178 canvas->save();
145 for (size_t i = 0; i < SK_ARRAY_COUNT(filters); ++i) { 179 for (size_t i = 0; i < SK_ARRAY_COUNT(filters); ++i) {
180 SkPaint paint;
181 canvas->drawBitmap(fCheckerboard, 0, 0);
146 drawProc[j](canvas, r, filters[i]); 182 drawProc[j](canvas, r, filters[i]);
147 canvas->translate(0, DY); 183 canvas->translate(0, DY);
148 } 184 }
149 canvas->restore(); 185 canvas->restore();
150 canvas->translate(DX, 0); 186 canvas->translate(DX, 0);
151 } 187 }
152 188
153 for(size_t j = 0; j < SK_ARRAY_COUNT(filters); ++j) { 189 for(size_t j = 0; j < SK_ARRAY_COUNT(filters); ++j) {
154 SkSafeUnref(filters[j]); 190 SkSafeUnref(filters[j]);
155 } 191 }
156 } 192 }
157 193
158 private: 194 private:
195 SkBitmap fCheckerboard;
159 typedef GM INHERITED; 196 typedef GM INHERITED;
160 }; 197 };
161 198
162 /////////////////////////////////////////////////////////////////////////////// 199 ///////////////////////////////////////////////////////////////////////////////
163 200
164 static skiagm::GM* MyFactory(void*) { return new ImageFiltersCroppedGM; } 201 static skiagm::GM* MyFactory(void*) { return new ImageFiltersCroppedGM; }
165 static skiagm::GMRegistry reg(MyFactory); 202 static skiagm::GMRegistry reg(MyFactory);
OLDNEW
« no previous file with comments | « no previous file | src/effects/SkMorphologyImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698