Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 78093005: Revert r17907 - Make it possible to add more than one piece of embedder data to isolates (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert r17907 - Make it possible to add more than one piece of embedder data to isolates > This will allow for using gin and blink bindings in the same process > > BUG=317398 > R=svenpanne@chromium.org, dcarney@chromium.org > LOG=y > > Review URL: https://codereview.chromium.org/77913003 BUG=none R=svenpanne@chromium.org TBR=svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=17915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -86 lines) Patch
M include/v8.h View 5 chunks +10 lines, -52 lines 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/isolate.h View 2 chunks +3 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +10 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-20 11:53:40 UTC) #1
Sven Panne
LGTM. (Cause for the revert: Alignment problems, right?)
7 years, 1 month ago (2013-11-20 11:55:53 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r17915.
7 years, 1 month ago (2013-11-20 12:05:52 UTC) #3
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-20 12:06:39 UTC) #4
Message was sent while issue was closed.
right. the class Isolate appears to be aligned differently on different
platforms :-/

Powered by Google App Engine
This is Rietveld 408576698