Ganesh text rendering cleanup.

Ganesh text rendering cleanup.

Rename GrTextStrike.{cpp.h} to GrFontCache.{cpp,h}
Move contents of GrTextStrike_impl.h to GrFontCache.h
Move glyph uploading to a separate function and remove harmful gotos
Add assert on glyph upload failure (shouldn't happen)

Committed: https://skia.googlesource.com/skia/+/787cdf9ab06c5afc6fe480ab88268e983505bd32

[jvanverth1, 2014-12-04 17:09:33]

jvanverth@google.com changed reviewers:
+ joshualitt@google.com, robertphillips@google.com

[jvanverth1, 2014-12-04 17:16:40]

It's not clear to me why we had separate GrTextStrike.h and GrTextStrike_impl.h
-- it's possible that GrTextStrike.h was originally part of the public
interface. There doesn't seem to be much point now other than maybe faster
compile times.

[joshualitt, 2014-12-04 17:35:59]

On 2014/12/04 17:16:40, jvanverth1 wrote:
> It's not clear to me why we had separate GrTextStrike.h and
GrTextStrike_impl.h
> -- it's possible that GrTextStrike.h was originally part of the public
> interface. There doesn't seem to be much point now other than maybe faster
> compile times.

I assume that uploadGlyph can't live on the base class for perf reasons?

lgtm

[jvanverth1, 2014-12-04 17:41:30]

On 2014/12/04 17:35:59, joshualitt wrote:
> On 2014/12/04 17:16:40, jvanverth1 wrote:
> > It's not clear to me why we had separate GrTextStrike.h and
> GrTextStrike_impl.h
> > -- it's possible that GrTextStrike.h was originally part of the public
> > interface. There doesn't seem to be much point now other than maybe faster
> > compile times.
> 
> I assume that uploadGlyph can't live on the base class for perf reasons?

fStrike is only part of GrBitmapTextContext and GrDistanceFieldTextContext, not
the base class. I have an open task to merge common functionality between them,
I can include uploadGlyph as part of that.

[jvanverth1, 2014-12-04 17:58:11]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-04 17:58:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780923002/1

[commit-bot: I haz the power, 2014-12-04 18:47:00]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/787cdf9ab06c5afc6fe480ab88268e983505bd32