ios/web/public/string_util.h - Issue 780873002: Upstream iOS web code.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/public/string_util.h

Issue 780873002: Upstream iOS web code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_WEB_PUBLIC_STRING_UTIL_H_

	6 #define IOS_WEB_PUBLIC_STRING_UTIL_H_

	7

	8 #include "base/strings/string16.h"

	9

	10 namespace web {

	11

	12 // Truncates \|contents\| to \|length\|.

	13 // Returns a string terminated at the last space to ensure no words are

	14 // clipped.

	15 // Note: This function uses spaces as word boundaries and may not handle all

	16 // languages correctly.

	17 base::string16 GetStringByClippingLastWord(const base::string16& contents,
	stuartmorgan 2014/12/04 23:22:58 We should revisit this at some point to figure out We should revisit this at some point to figure out if we can put it somewhere better than web; it's pretty random a part of web/public/ droger 2014/12/09 13:14:43 I agree. This function has only one caller, and it Show quoted text On 2014/12/04 23:22:58, stuartmorgan wrote: > We should revisit this at some point to figure out if we can put it somewhere > better than web; it's pretty random a part of web/public/ I agree. This function has only one caller, and it is in translate. It was originally in translate, but Shreyas moved it to chrome/common here: https://chromereviews.googleplex.com/80307013/ I tried to move it back to translate, but apparently there was a discussion it was decided to put it in web. See comments here: https://chromereviews.googleplex.com/96607013/diff/180001/components/translat...
	18 size_t length);

	19

	20 } // namespace web

	21

	22 #endif // IOS_WEB_PUBLIC_STRING_UTIL_H_

OLD	NEW

« ios/web/ios_web.gyp ('K') | « ios/web/public/referrer.h ('k') | ios/web/public/web_state/web_state_observer.h » ('j') | ios/web/public/web_state/web_state_observer.h » ('J')