Issue 780833002: Revert of Encode reservation meta data in the snapshot blob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 780833002: Revert of Encode reservation meta data in the snapshot blob. (Closed)

Created:
6 years ago by Michael Achenbach

Modified:
6 years ago

Reviewers:
baixo, vogelheim, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@snapshotformat

Project:
v8

Visibility:
Public.

Revert of Encode reservation meta data in the snapshot blob. (patchset #3 id:40001 of https://codereview.chromium.org/781443002/) Reason for revert: [sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/1540 Original issue's description: > Encode reservation meta data in the snapshot blob. > > This also makes reserving multiple chunks per object space possible. > > R=vogelheim@chromium.org TBR=vogelheim@chromium.org,baixo@chromium.org,yangguo@chromium.org NOTREECHECKS=true NOTRY=true

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+611 lines, -376 lines)			Patch
M	src/mksnapshot.cc	View	7 chunks	+137 lines, -38 lines	0 comments	Download
M	src/natives-external.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/serialize.h	View	9 chunks	+98 lines, -104 lines	0 comments	Download
M	src/serialize.cc	View	23 chunks	+95 lines, -174 lines	0 comments	Download
M	src/snapshot.h	View	1 chunk	+23 lines, -1 line	0 comments	Download
M	src/snapshot-common.cc	View	2 chunks	+32 lines, -8 lines	0 comments	Download
M	src/snapshot-empty.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/snapshot-external.cc	View	4 chunks	+74 lines, -10 lines	0 comments	Download
M	src/snapshot-source-sink.h	View	2 chunks	+4 lines, -9 lines	0 comments	Download
M	src/snapshot-source-sink.cc	View	2 chunks	+14 lines, -7 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	9 chunks	+110 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Created Revert of Encode reservation meta data in the snapshot blob.

6 years ago (2014-12-04 10:30:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780833002/1

6 years ago (2014-12-04 10:31:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)