Make CryptoResultImpl not to use WeakPtr.

Source/modules/crypto/CryptoResultImpl.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 53 matching lines @@
     virtual void completeWithJson(const char* utf8Data, unsigned length) override;
     virtual void completeWithBoolean(bool) override;
     virtual void completeWithKey(const WebCryptoKey&) override;
     virtual void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCryptoKey& privateKey) override;
     virtual bool cancelled() const override;
 
     // If called after completion (including cancellation) will return an empty
     // ScriptPromise.
     ScriptPromise promise();
 
 private:

[yhirano, 2014/12/11 12:28:41]

By making Resolver this class's inner class and having m_resolver as
RawPtr<Resolver>, you can save friend declaration and down cast.

[tasak, 2014/12/12 07:56:51]

Done.

-    class WeakResolver;
     explicit CryptoResultImpl(ScriptState*);
 
+    void clearResolver();
     void cancel();
 
-    WeakPtr<ScriptPromiseResolver> m_resolver;
+    // Since ScriptPromiseResolver destroys itself, we should not use RefPtr

[haraken, 2014/12/12 00:04:11]

Just help me understand: Where is the ScriptPromiseResolver destroyed?

[tasak, 2014/12/12 07:56:51]

ScriptPromiseResolver destorys itself.
So basically we should not hold ScriptPromiseResolver.

+    // here. So to avoid using stale pointer, m_resolver should be cleared
+    // after resolving.
+    // FIXME: ScriptPromiseResolver should not be exported.
+    // Instead, use ScriptPromise.
+    RawPtr<ScriptPromiseResolver> m_resolver;

[haraken, 2014/12/12 00:04:10]

RawPtr<ScriptPromiseResolver> => ScriptPromiseResolver*

[tasak, 2014/12/12 07:56:51]

Done.

     volatile int m_cancelled;
+
+    friend class CryptoResultResolver;
 };
 
 } // namespace blink
 
 #endif