Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 780793002: Make CryptoResultImpl not to use WeakPtr. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 virtual void completeWithBoolean(bool) override; 65 virtual void completeWithBoolean(bool) override;
66 virtual void completeWithKey(const WebCryptoKey&) override; 66 virtual void completeWithKey(const WebCryptoKey&) override;
67 virtual void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCry ptoKey& privateKey) override; 67 virtual void completeWithKeyPair(const WebCryptoKey& publicKey, const WebCry ptoKey& privateKey) override;
68 virtual bool cancelled() const override; 68 virtual bool cancelled() const override;
69 69
70 // If called after completion (including cancellation) will return an empty 70 // If called after completion (including cancellation) will return an empty
71 // ScriptPromise. 71 // ScriptPromise.
72 ScriptPromise promise(); 72 ScriptPromise promise();
73 73
74 private: 74 private:
75 class WeakResolver; 75 class Resolver;
76 explicit CryptoResultImpl(ScriptState*); 76 explicit CryptoResultImpl(ScriptState*);
77 77
78 void clearResolver();
78 void cancel(); 79 void cancel();
79 80
80 WeakPtr<ScriptPromiseResolver> m_resolver; 81 // FIXME: ScriptPromiseResolver should not be exported.
82 // Instead, use ScriptPromise.
83 ScriptPromiseResolver* m_resolver;
81 volatile int m_cancelled; 84 volatile int m_cancelled;
82 }; 85 };
83 86
84 } // namespace blink 87 } // namespace blink
85 88
86 #endif 89 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698