Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 780733002: Simplify the thunk targets since we don't support apps as components (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan, blundell
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Simplify the thunk targets since we don't support apps as components Since we don't support using the component build to produce mojo apps, we can simplify the build targets in a few ways: *) every mojo_native_application must depend on the c system thunks, so just make that part of the template instead of requiring the dep *) there's no such thing as depending on gles2 headers from a component, so delete the forwarding group. Most targets that want to use the gles2 headers in a mojo context want to depend on an implementation through the thunks, so //mojo/public/c/gles2 does just that. A smaller number of targets (such as the implementation of the thunks) want to just depend on the headers but not an impl, so they can depend on //mojo/public/c/gles2:headers. The //mojo/public/gles target isn't that useful since the only thing we expose is a set of C entry points. We can probably also simplify the c system targets, but that's trickier due to more extensive use from the chromium side. BUG=438701 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c41ad161b87d3631bf3a44170cecb5d8634d681c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -154 lines) Patch
M benchmarks/startup/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M examples/apptest/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M examples/aura_demo/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M examples/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/content_handler_demo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/echo/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M examples/embedded_app/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M examples/http_handler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/indirect_service/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M examples/keyboard/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/media_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/sample_app/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M examples/sky_compositor_app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 3 chunks +1 line, -4 lines 0 comments Download
M examples/wget/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M examples/window_manager/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M examples/wm_flow/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/geometry/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 3 chunks +3 lines, -8 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/gles2/gles2_impl_export.h View 1 chunk +0 lines, -31 lines 0 comments Download
M mojo/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/gles2/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
D mojo/public/gles2/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/platform/native/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/network/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/network/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/package_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/clipboard/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/http_server/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/js/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M services/js/modules/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M services/test_service/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M services/window_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/compositor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/services/inspector/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/debugger/prompt/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/tester/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
6 years ago (2014-12-04 00:06:44 UTC) #1
viettrungluu
LGTM. You break it, you buy it.
6 years ago (2014-12-04 00:23:20 UTC) #2
jamesr
6 years ago (2014-12-04 00:25:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c41ad161b87d3631bf3a44170cecb5d8634d681c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698