Load VideoToolbox even when --no-sandbox is in use.

Load VideoToolbox even when --no-sandbox is in use.

BUG=133828
Committed: https://crrev.com/700b4610ee8d5a73d2fe8465917589fab8818fbd
Cr-Commit-Position: refs/heads/master@{#307112}

[sandersd (OOO until July 31), 2014-12-04 01:31:25]

sandersd@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2014-12-04 01:57:31]

https://codereview.chromium.org/780713004/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vt_video_decode_accelerator.cc (right):

https://codereview.chromium.org/780713004/diff/20001/content/common/gpu/media...
content/common/gpu/media/vt_video_decode_accelerator.cc:35: // Track
VideoToolbox loaded to make sure that loading is attempted once and
Seems instead you should be using a LazyInstance::Leaky to ensure startup is
only attempted once. See how this is done in media/base/media.cc --
Alternatively you can find a place which can track this without the use of
globals (note: we typically prefix these with "g_" too)

[sandersd (OOO until July 31), 2014-12-04 02:05:48]

https://codereview.chromium.org/780713004/diff/20001/content/common/gpu/media...
File content/common/gpu/media/vt_video_decode_accelerator.cc (right):

https://codereview.chromium.org/780713004/diff/20001/content/common/gpu/media...
content/common/gpu/media/vt_video_decode_accelerator.cc:35: // Track
VideoToolbox loaded to make sure that loading is attempted once and
On 2014/12/04 01:57:31, DaleCurtis wrote:
> Seems instead you should be using a LazyInstance::Leaky to ensure startup is
> only attempted once. See how this is done in media/base/media.cc --
> Alternatively you can find a place which can track this without the use of
> globals (note: we typically prefix these with "g_" too)

That seems rather complicated for this use case, specifically because there is
no actual object to represent the loaded library (so a fake one would need to be
created).

The generated stub does include its own static that has this information
(accessed by IsVtInitialized() as the previous code did), but if I use that from
Initialize() then it will try to load it every time if it is failing.

I could remove g_vt_load_successful and use acombination of g_vt_load_attempted
and IsVtInitialized().

[DaleCurtis, 2014-12-04 02:30:46]

lgtm

[sandersd (OOO until July 31), 2014-12-05 21:32:24]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-12-05 21:33:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780713004/80001

[commit-bot: I haz the power, 2014-12-05 21:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-05 21:37:28]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/90639)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sandersd (OOO until July 31), 2014-12-05 22:24:48]

The CQ bit was checked by sandersd@chromium.org

[commit-bot: I haz the power, 2014-12-05 22:26:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780713004/100001

[commit-bot: I haz the power, 2014-12-05 23:33:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-12-05 23:34:49]

Patchset 6 (id:??) landed as
https://crrev.com/700b4610ee8d5a73d2fe8465917589fab8818fbd
Cr-Commit-Position: refs/heads/master@{#307112}