Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: content/common/gpu/client/context_provider_command_buffer.cc

Issue 780653007: Added GL_CHROMIUM_trace_marker feature as well as gpu_toplevel markers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated CHROMIUM_trace_marker.txt date and brace error Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/context_provider_command_buffer.cc
diff --git a/content/common/gpu/client/context_provider_command_buffer.cc b/content/common/gpu/client/context_provider_command_buffer.cc
index a4c3111c0cea56475463ae9eac507a986afb95b3..f1aaa884350c70d2ac242044b3fa42ce41b6da1a 100644
--- a/content/common/gpu/client/context_provider_command_buffer.cc
+++ b/content/common/gpu/client/context_provider_command_buffer.cc
@@ -98,7 +98,7 @@ bool ContextProviderCommandBuffer::BindToCurrentThread() {
std::string unique_context_name =
base::StringPrintf("%s-%p", debug_name_.c_str(), context3d_.get());
- context3d_->pushGroupMarkerEXT(unique_context_name.c_str());
+ context3d_->traceBeginCHROMIUM("gpu_toplevel", unique_context_name.c_str());
lost_context_callback_proxy_.reset(new LostContextCallbackProxy(this));
context3d_->GetCommandBufferProxy()->SetMemoryAllocationChangedCallback(
@@ -199,6 +199,7 @@ void ContextProviderCommandBuffer::InitializeCapabilities() {
bool ContextProviderCommandBuffer::DestroyedOnMainThread() {
DCHECK(main_thread_checker_.CalledOnValidThread());
+ context3d_->traceEndCHROMIUM();
vmiura 2014/12/18 19:30:27 Likewise, can we just remove this call, as GL_CHRO
David Yen 2014/12/18 21:25:59 Done.
base::AutoLock lock(main_thread_lock_);
return destroyed_;

Powered by Google App Engine
This is Rietveld 408576698