|
Revert of Upgrade the windows specific version of LaunchProcess to avoid raw handles. (patchset #3 id:40001 of https://codereview.chromium.org/759903002/)
Reason for revert:
Looks like it broke the 'Google Chrome Win' builder:
FAILED: ninja -t msvc -e environment.x86 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\win8\delegate_execute\delegate_execute.chrome_util.obj.rsp /c ..\..\win8\delegate_execute\chrome_util.cc /Foobj\win8\delegate_execute\delegate_execute.chrome_util.obj /Fdobj\win8\delegate_execute\delegate_execute.cc.pdb
c:\b\build\slave\google-chrome-rel-win\build\src\win8\delegate_execute\chrome_util.cc(119) : error C2665: 'base::LaunchProcess' : none of the 3 overloads could convert all the argument types
c:\b\build\slave\google-chrome-rel-win\build\src\base\process\launch.h(161): could be 'bool base::LaunchProcess(const base::CommandLine &,const base::LaunchOptions &,base::ProcessHandle *)'
while trying to match the argument list '(base::string16, base::LaunchOptions, base::win::ScopedHandle *)'
Original issue's description:
> Upgrade the windows specific version of LaunchProcess to avoid raw handles.
>
> This change implies that extensions::LaunchNativeProcess also changes to
> return base::Process, and that requires base::EnsureProcessTerminated to
> deal with base:Process (as it basically claims ownership of the process).
>
> This CL fixes some leaks all around.
>
> BUG= 417532
>
> Committed: https://crrev.com/6b687a5e232c80539772dc3dbe35b98095064c38
> Cr-Commit-Position: refs/heads/master@{#306687}
TBR=cpu@chromium.org,finnur@chromium.org,gab@chromium.org,sergeyu@chromium.org,wez@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 417532
Committed: https://crrev.com/44b0c750ff6588cc893766ea74d3ff0203d46d75
Cr-Commit-Position: refs/heads/master@{#306712}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+100 lines, -107 lines) |
Patch |
 |
M |
base/process/kill.h
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
base/process/kill_mac.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
base/process/kill_posix.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
base/process/kill_win.cc
|
View
|
|
5 chunks |
+15 lines, -12 lines |
0 comments
|
Download
|
 |
M |
base/process/launch.h
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
base/process/launch_win.cc
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
base/process/process_util_unittest.cc
|
View
|
|
2 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_message_process_host.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_message_process_host.cc
|
View
|
|
4 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_process_launcher.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_process_launcher.cc
|
View
|
|
4 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
|
View
|
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/first_run/upgrade_util_win.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/uninstall_view.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/installer/gcapi/gcapi.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/installer/test/alternate_version_generator.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/installer/util/google_update_util.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/installer/util/install_util.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
cloud_print/virtual_driver/win/install/setup.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/storage_monitor/storage_monitor_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/child_process_launcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/zygote/zygote_linux.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
remoting/host/setup/daemon_installer_win.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
win8/test/metro_registration_helper.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|