Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 78063002: Don't generate useless string checks for string adds. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Don't generate useless string checks for string adds. If we know that one side of a string add is definitely a string (i.e. if it's a string constant), then we don't need to emit a string check for the argument. This adds a new BuildCheckString() method to the graph builder, which does "the right thing". TEST=mjsunit/string-add R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Michael, This is an obvious optimization for inline binary operations in crankshaft. PTAL -- ...
7 years, 1 month ago (2013-11-20 10:15:23 UTC) #1
mvstanton
Be sure to use the method soon :). lgtm.
7 years, 1 month ago (2013-11-20 11:51:08 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-11-20 11:53:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17912.

Powered by Google App Engine
This is Rietveld 408576698