Update unit test file format.

Update unit test file format.

This CL update the unit test file format to use JSON. It allows to
specify test specific information (disabled, cacheable), and also
annotate the tests that can be run on android, so that the android
specific test list can be removed.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/5291598e81669cdd8740ff571b18c6462a564d4d

[viettrungluu, 2014-12-03 16:15:37]

https://codereview.chromium.org/780563002/diff/1/mojo/tools/data/unittests
File mojo/tools/data/unittests (right):

https://codereview.chromium.org/780563002/diff/1/mojo/tools/data/unittests#ne...
mojo/tools/data/unittests:4: # System tests:
This is obviously not JSON. What is it?

https://codereview.chromium.org/780563002/diff/1/mojo/tools/test_runner.py
File mojo/tools/test_runner.py (right):

https://codereview.chromium.org/780563002/diff/1/mojo/tools/test_runner.py#ne...
mojo/tools/test_runner.py:47: [l for l in f.readlines() if not
l.lstrip().startswith('#')])
I see.

Rather than doing something weird, why don't you just say that the file should
be a valid Python dictionary and eval() it (like gyp)?

(Then you'll get proper comments, including same-line comments, and trailing
commas in dictionaries/lists.)

https://codereview.chromium.org/780563002/diff/1/mojo/tools/test_runner.py#ne...
mojo/tools/test_runner.py:86: if args.android and not
gtest_dict.get("run_on_android"):
Having arbitrary/hacky entries like run_on_android kind of speaks to why having
a non-programmatic test list format is doomed to failure. (It's not a successful
format if you have to keep on modifying the consumer(s) of the list to support
various conditions.)

Soon-ish, I want to extract the higher-level list out of get_test_list.py into
something that's exec'ed in Python, which will provide a cleaner programmatic
model and separation between (programmatic) "data" and code.

For now, I can live with this sort of thing (except we shouldn't bother with
pretending that it's JSON), but it's not really that much (if any) better than
just embedding the test list directly in this file....

[qsr, 2014-12-03 16:38:32]

https://codereview.chromium.org/780563002/diff/1/mojo/tools/test_runner.py
File mojo/tools/test_runner.py (right):

https://codereview.chromium.org/780563002/diff/1/mojo/tools/test_runner.py#ne...
mojo/tools/test_runner.py:47: [l for l in f.readlines() if not
l.lstrip().startswith('#')])
On 2014/12/03 16:15:37, viettrungluu wrote:
> I see.
> 
> Rather than doing something weird, why don't you just say that the file should
> be a valid Python dictionary and eval() it (like gyp)?
> 
> (Then you'll get proper comments, including same-line comments, and trailing
> commas in dictionaries/lists.)

Done.

[viettrungluu, 2014-12-03 18:19:50]

LGTM

[qsr, 2014-12-04 08:33:06]

Committed patchset #2 (id:20001) manually as
5291598e81669cdd8740ff571b18c6462a564d4d (presubmit successful).