Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780553002: Switch content/ to use AX_STATE_DISABLE instead of AX_STATE_ENABLED.

Created:
6 years ago by shreeramk
Modified:
3 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch content/ to use AX_STATE_DISABLE instead of AX_STATE_ENABLED. BUG=none

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
shreeramk
6 years ago (2014-12-19 04:23:26 UTC) #2
dmazzoni
https://codereview.chromium.org/780553002/diff/1/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/780553002/diff/1/ui/accessibility/ax_enums.idl#newcode195 ui/accessibility/ax_enums.idl:195: enabled, // content only Can we delete this one ...
6 years ago (2014-12-22 08:11:30 UTC) #3
shreeramk
6 years ago (2014-12-22 10:30:54 UTC) #4 
https://codereview.chromium.org/780553002/diff/1/ui/accessibility/ax_enums.idl
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/780553002/diff/1/ui/accessibility/ax_enums.id...
ui/accessibility/ax_enums.idl:195: enabled,   // content only
On 2014/12/22 08:11:30, dmazzoni wrote:
> Can we delete this one now?

@Dominic: I have a doubt.

"switch content/ to use AX_STATE_DISABLED instead of !AX_STATE_ENABLED".

That means I shouldn't change all AX_STATE_ENABLED to AX_STATE_DISABLED. We
should only change the places where !AX_STATE_ENABLED is used.

Is I am correct?

Powered by Google App Engine
This is Rietveld 408576698