Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: Source/modules/indexeddb/IDBFactoryBackendImpl.cpp

Issue 78053006: [oilpan] Move IDBDatabase, IDBDatabaseCallbacks, IDBDatabaseBackendInterface and other related clas… (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBFactoryBackendImpl.cpp
diff --git a/Source/modules/indexeddb/IDBFactoryBackendImpl.cpp b/Source/modules/indexeddb/IDBFactoryBackendImpl.cpp
index 0c2f1840303c33c16b4af7c16f672342dc368942..f7ab99344edf92d032b4132e9c2925a40f9f4f3c 100644
--- a/Source/modules/indexeddb/IDBFactoryBackendImpl.cpp
+++ b/Source/modules/indexeddb/IDBFactoryBackendImpl.cpp
@@ -109,9 +109,9 @@ void IDBFactoryBackendImpl::deleteDatabase(const String& name, PassRefPtr<IDBCal
return;
}
- RefPtr<IDBDatabaseBackendImpl> databaseBackend = IDBDatabaseBackendImpl::create(name, backingStore.get(), this, uniqueIdentifier);
+ IDBDatabaseBackendImpl* databaseBackend = IDBDatabaseBackendImpl::create(name, backingStore.get(), this, uniqueIdentifier);
if (databaseBackend) {
- m_databaseBackendMap.set(uniqueIdentifier, databaseBackend.get());
+ m_databaseBackendMap.set(uniqueIdentifier, databaseBackend);
databaseBackend->deleteDatabase(callbacks);
m_databaseBackendMap.remove(uniqueIdentifier);
} else
@@ -149,12 +149,12 @@ PassRefPtr<IDBBackingStore> IDBFactoryBackendImpl::openBackingStore(const String
return 0;
}
-void IDBFactoryBackendImpl::open(const String& name, int64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks> callbacks, PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks, const String& databaseIdentifier, ScriptExecutionContext*, const String& dataDirectory)
+void IDBFactoryBackendImpl::open(const String& name, int64_t version, int64_t transactionId, PassRefPtr<IDBCallbacks> callbacks, IDBDatabaseCallbacks* databaseCallbacks, const String& databaseIdentifier, ScriptExecutionContext*, const String& dataDirectory)
{
IDB_TRACE("IDBFactoryBackendImpl::open");
const String uniqueIdentifier = computeUniqueIdentifier(name, databaseIdentifier);
- RefPtr<IDBDatabaseBackendImpl> databaseBackend;
+ IDBDatabaseBackendImpl* databaseBackend;
IDBDatabaseBackendMap::iterator it = m_databaseBackendMap.find(uniqueIdentifier);
if (it == m_databaseBackendMap.end()) {
RefPtr<IDBBackingStore> backingStore = openBackingStore(databaseIdentifier, dataDirectory);
@@ -165,7 +165,7 @@ void IDBFactoryBackendImpl::open(const String& name, int64_t version, int64_t tr
databaseBackend = IDBDatabaseBackendImpl::create(name, backingStore.get(), this, uniqueIdentifier);
if (databaseBackend)
- m_databaseBackendMap.set(uniqueIdentifier, databaseBackend.get());
+ m_databaseBackendMap.set(uniqueIdentifier, databaseBackend);
else {
callbacks->onError(IDBDatabaseError::create(IDBDatabaseException::UnknownError, "Internal error creating database backend for indexeddb.open."));
return;

Powered by Google App Engine
This is Rietveld 408576698