Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/WebKit/chromium/tests/IDBTransactionTest.cpp

Issue 78053006: [oilpan] Move IDBDatabase, IDBDatabaseCallbacks, IDBDatabaseBackendInterface and other related clas… (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/tests/IDBTransactionTest.cpp
diff --git a/Source/WebKit/chromium/tests/IDBTransactionTest.cpp b/Source/WebKit/chromium/tests/IDBTransactionTest.cpp
index 1498610ac5a30699a700048d229a63a5946af0f6..8185e4b8ca27cc0379bfa28e765a55d13c4dfdd4 100644
--- a/Source/WebKit/chromium/tests/IDBTransactionTest.cpp
+++ b/Source/WebKit/chromium/tests/IDBTransactionTest.cpp
@@ -84,12 +84,12 @@ private:
class FakeIDBDatabaseBackendProxy : public IDBDatabaseBackendInterface {
public:
- static PassRefPtr<FakeIDBDatabaseBackendProxy> create() { return adoptRef(new FakeIDBDatabaseBackendProxy()); }
+ static FakeIDBDatabaseBackendProxy* create() { return new FakeIDBDatabaseBackendProxy(); }
virtual void createObjectStore(int64_t transactionId, int64_t objectStoreId, const String& name, const IDBKeyPath&, bool autoIncrement) OVERRIDE { }
virtual void deleteObjectStore(int64_t transactionId, int64_t objectStoreId) OVERRIDE { }
- virtual void createTransaction(int64_t transactionId, PassRefPtr<IDBDatabaseCallbacks>, const Vector<int64_t>& objectStoreIds, unsigned short mode) OVERRIDE { }
- virtual void close(PassRefPtr<IDBDatabaseCallbacks>) OVERRIDE { }
+ virtual void createTransaction(int64_t transactionId, IDBDatabaseCallbacks*, const Vector<int64_t>& objectStoreIds, unsigned short mode) OVERRIDE { }
+ virtual void close(IDBDatabaseCallbacks*) OVERRIDE { }
virtual void commit(int64_t transactionId) OVERRIDE { }
virtual void abort(int64_t transactionId) OVERRIDE { }
@@ -107,17 +107,20 @@ public:
virtual void deleteRange(int64_t transactionId, int64_t objectStoreId, PassRefPtr<IDBKeyRange>, PassRefPtr<IDBCallbacks>) OVERRIDE { }
virtual void clear(int64_t transactionId, int64_t objectStoreId, PassRefPtr<IDBCallbacks>) OVERRIDE { }
+ virtual void trace(Visitor*) const OVERRIDE { }
+
private:
FakeIDBDatabaseBackendProxy() { }
};
class FakeIDBDatabaseCallbacks : public IDBDatabaseCallbacks {
public:
- static PassRefPtr<FakeIDBDatabaseCallbacks> create() { return adoptRef(new FakeIDBDatabaseCallbacks()); }
+ static FakeIDBDatabaseCallbacks* create() { return new FakeIDBDatabaseCallbacks(); }
virtual void onVersionChange(int64_t oldVersion, int64_t newVersion) OVERRIDE { }
virtual void onForcedClose() OVERRIDE { }
virtual void onAbort(int64_t transactionId, PassRefPtr<IDBDatabaseError> error) OVERRIDE { }
virtual void onComplete(int64_t transactionId) OVERRIDE { }
+ virtual void trace(Visitor*) const OVERRIDE { }
private:
FakeIDBDatabaseCallbacks() { }
};
@@ -127,8 +130,8 @@ TEST_F(IDBTransactionTest, EnsureLifetime)
v8::HandleScope handleScope;
v8::Context::Scope scope(context());
- RefPtr<FakeIDBDatabaseBackendProxy> proxy = FakeIDBDatabaseBackendProxy::create();
- RefPtr<FakeIDBDatabaseCallbacks> connection = FakeIDBDatabaseCallbacks::create();
+ FakeIDBDatabaseBackendProxy* proxy = FakeIDBDatabaseBackendProxy::create();
+ FakeIDBDatabaseCallbacks* connection = FakeIDBDatabaseCallbacks::create();
RefPtr<IDBDatabase> db = IDBDatabase::create(scriptExecutionContext(), proxy, connection);
const int64_t transactionId = 1234;

Powered by Google App Engine
This is Rietveld 408576698