Source/WebKit/chromium/src/IDBCallbacksProxy.h - Issue 78053006: [oilpan] Move IDBDatabase, IDBDatabaseCallbacks, IDBDatabaseBackendInterface and other related clas…

Unified Diff: Source/WebKit/chromium/src/IDBCallbacksProxy.h

Issue 78053006: [oilpan] Move IDBDatabase, IDBDatabaseCallbacks, IDBDatabaseBackendInterface and other related clas… (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/IDBCallbacksProxy.h

diff --git a/Source/WebKit/chromium/src/IDBCallbacksProxy.h b/Source/WebKit/chromium/src/IDBCallbacksProxy.h

index 5aaf130b2ecb855ecc13de34f0827eadb1bd42fe..afa024b37b643e493ee8f21b325545828f93a4ad 100644

--- a/Source/WebKit/chromium/src/IDBCallbacksProxy.h

+++ b/Source/WebKit/chromium/src/IDBCallbacksProxy.h

@@ -41,13 +41,13 @@ class IDBDatabaseCallbacksProxy;

class IDBCallbacksProxy : public WebCore::IDBCallbacks {

public:

- static PassRefPtr<IDBCallbacksProxy> create(PassOwnPtr<WebIDBCallbacks>);

+ static IDBCallbacksProxy* create(PassOwnPtr<WebIDBCallbacks>);

virtual ~IDBCallbacksProxy();

virtual void onError(PassRefPtr<WebCore::IDBDatabaseError>);

virtual void onSuccess(const Vector<String>&);

virtual void onSuccess(PassRefPtr<WebCore::IDBCursorBackendInterface>, PassRefPtr<WebCore::IDBKey>, PassRefPtr<WebCore::IDBKey> primaryKey, PassRefPtr<WebCore::SharedBuffer>);

- virtual void onSuccess(PassRefPtr<WebCore::IDBDatabaseBackendInterface>, const WebCore::IDBDatabaseMetadata&);

+ virtual void onSuccess(WebCore::IDBDatabaseBackendInterface*, const WebCore::IDBDatabaseMetadata&);

virtual void onSuccess(PassRefPtr<WebCore::IDBKey>);

virtual void onSuccess(PassRefPtr<WebCore::SharedBuffer>);

virtual void onSuccess(PassRefPtr<WebCore::SharedBuffer>, PassRefPtr<WebCore::IDBKey>, const WebCore::IDBKeyPath&);

@@ -56,15 +56,15 @@ public:

virtual void onSuccess(PassRefPtr<WebCore::IDBKey>, PassRefPtr<WebCore::IDBKey> primaryKey, PassRefPtr<WebCore::SharedBuffer>);

virtual void onSuccessWithPrefetch(const Vector<RefPtr<WebCore::IDBKey> >& keys, const Vector<RefPtr<WebCore::IDBKey> >& primaryKeys, const Vector<RefPtr<WebCore::SharedBuffer> >& values);

virtual void onBlocked(int64_t existingVersion);

- virtual void onUpgradeNeeded(int64_t oldVersion, PassRefPtr<WebCore::IDBDatabaseBackendInterface>, const WebCore::IDBDatabaseMetadata&);

+ virtual void onUpgradeNeeded(int64_t oldVersion, WebCore::IDBDatabaseBackendInterface*, const WebCore::IDBDatabaseMetadata&);

- void setDatabaseCallbacks(PassRefPtr<IDBDatabaseCallbacksProxy>);

+ void setDatabaseCallbacks(IDBDatabaseCallbacksProxy*);

private:

IDBCallbacksProxy(PassOwnPtr<WebIDBCallbacks>);

OwnPtr<WebIDBCallbacks> m_callbacks;

- RefPtr<IDBDatabaseCallbacksProxy> m_databaseCallbacks;

+ WebCore::Persistent<IDBDatabaseCallbacksProxy> m_databaseCallbacks;

Mads Ager (chromium) 2013/11/28 10:24:46 This will put a Persistent in our heap I think. Th

haraken 2013/12/02 09:13:27 Done.

bool m_didComplete;

bool m_didCreateProxy;

};

« no previous file with comments | « no previous file | Source/WebKit/chromium/src/IDBCallbacksProxy.cpp » ('j') | Source/WebKit/chromium/src/WebIDBCallbacksImpl.h » ('J')