Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h

Issue 78053006: [oilpan] Move IDBDatabase, IDBDatabaseCallbacks, IDBDatabaseBackendInterface and other related clas… (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h
diff --git a/Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h b/Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h
index d4f2ca69c934d71bf01ff352df07aa3ec2e452dd..f663ae924235c77896baaab957a2674170ba08d8 100644
--- a/Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h
+++ b/Source/modules/indexeddb/IDBDatabaseCallbacksImpl.h
@@ -36,7 +36,7 @@ class IDBDatabase;
class IDBDatabaseCallbacksImpl : public IDBDatabaseCallbacks {
public:
- static PassRefPtr<IDBDatabaseCallbacksImpl> create();
+ static IDBDatabaseCallbacksImpl* create();
virtual ~IDBDatabaseCallbacksImpl();
// IDBDatabaseCallbacks
@@ -48,10 +48,14 @@ public:
void connect(IDBDatabase*);
+ virtual void trace(Visitor*);
+
private:
IDBDatabaseCallbacksImpl();
- // The initial IDBOpenDBRequest or final IDBDatabase maintains a RefPtr to this
+ // The initial IDBOpenDBRequest or final IDBDatabase maintains a RefPtr to this.
+ // FIXME(oilpan): We should make this a Member once we move the entire IndexedDB hierarchy to the heap.
+ // We cannot make it a Member at this point since changing a raw pointer to a Member can create a cycle.
IDBDatabase* m_database;
};
« no previous file with comments | « Source/modules/indexeddb/IDBDatabaseCallbacks.h ('k') | Source/modules/indexeddb/IDBDatabaseCallbacksImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698