Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 78053002: Experimental lexer generator: rename_things(Dfa minimization) += comments part 2 (Closed)

Created:
7 years, 1 month ago by marja
Modified:
7 years, 1 month ago
Reviewers:
CC:
v8-dev
Visibility:
Public.

Description

Experimental lexer generator: rename_things(Dfa minimization) += comments part 2 - id_map -> state_to_id - reverse_id_map -> id_to_state - __merge_partitions -> __create_states_from_partitions - name_map -> partition_to_name - reverse_partition_map -> state_id_to_partition - mapping -> partition_name_to_node - transition_id -> transition_state_id (moar) - x -> state_id - map_into_partition -> states_transitioning_to_test_partition (still not a great name) BUG= Committed: https://code.google.com/p/v8/source/detail?r=17904

Patch Set 1 #

Patch Set 2 : wrong way #

Patch Set 3 : wrong way try 2 #

Patch Set 4 : moved comments #

Patch Set 5 : new try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -52 lines) Patch
M tools/lexer_generator/dfa.py View 1 2 3 8 chunks +86 lines, -52 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
7 years, 1 month ago (2013-11-20 10:31:23 UTC) #1
Message was sent while issue was closed.
Committed patchset #5 manually as r17904.

Powered by Google App Engine
This is Rietveld 408576698