Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780503003: [DevTools] Resizing DevTools window should clear autocomplete text from console prompt. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
vivekg, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DevTools] Resizing DevTools window should clear autocomplete text from console prompt. Resizing DevTools window causes the suggestion box to be hidden but the autocomplete text remains on the prompt. This CL clears it off. R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186422

Patch Set 1 #

Total comments: 1

Patch Set 2 : introducing _hidePromptSuggestBox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Source/devtools/front_end/console/ConsoleView.js View 1 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vivekg
Hello Pavel, missed this in earlier CL today. Can you please take a look?
6 years ago (2014-12-03 09:02:47 UTC) #2
pfeldman
https://codereview.chromium.org/780503003/diff/1/Source/devtools/front_end/console/ConsoleView.js File Source/devtools/front_end/console/ConsoleView.js (right): https://codereview.chromium.org/780503003/diff/1/Source/devtools/front_end/console/ConsoleView.js#newcode472 Source/devtools/front_end/console/ConsoleView.js:472: this._prompt.clearAutoComplete(true); lgtm Do we think these two come together? ...
6 years ago (2014-12-03 12:34:38 UTC) #3
vivekg
On 2014/12/03 at 12:34:38, pfeldman wrote: > https://codereview.chromium.org/780503003/diff/1/Source/devtools/front_end/console/ConsoleView.js > File Source/devtools/front_end/console/ConsoleView.js (right): > > https://codereview.chromium.org/780503003/diff/1/Source/devtools/front_end/console/ConsoleView.js#newcode472 ...
6 years ago (2014-12-03 12:35:52 UTC) #4
vivekg
Done, PTAL. Thanks!
6 years ago (2014-12-03 13:17:59 UTC) #5
pfeldman
lgtm
6 years ago (2014-12-03 13:18:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780503003/20001
6 years ago (2014-12-03 13:20:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 14:34:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186422

Powered by Google App Engine
This is Rietveld 408576698