Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 780503002: [turbofan] Initial work on cleaning up the Node class. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial work on cleaning up the Node class. - Remove use_count_, only used for debug builds and tests. - Use BitField instead of the unreliable C++ bit fields. - Improve memory layout. R=mstarzinger@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -48 lines) Patch
M src/compiler/node.h View 13 chunks +50 lines, -38 lines 0 comments Download
M src/compiler/node.cc View 4 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
6 years ago (2014-12-03 08:53:13 UTC) #1
Benedikt Meurer
PTAL
6 years ago (2014-12-03 08:53:37 UTC) #2
Michael Starzinger
LGTM.
6 years ago (2014-12-03 09:55:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780503002/1
6 years ago (2014-12-03 10:07:32 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 10:33:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698