Issue 780493002: Remove Google Storage scheme prefix correctly from gs base name in webpages_playback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 780493002: Remove Google Storage scheme prefix correctly from gs base name in webpages_playback (Closed)

Created:
6 years ago by Kimmo Kinnunen

Modified:
6 years ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@webpages-replay-run-render-pdf

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove Google Storage scheme prefix correctly from gs base name in webpages_playback In python, str.lstrip([chars]) means "lstrip any of the chars from str", not "remove prefix". Thus "gs://skia".lstrip("gs://") yields "kia". Replace with custom function stripping the prefix from lstrip()ed gs base name. Committed: https://skia.googlesource.com/skia/+/e75d2d2d995dad4eeed1bd306ef987adabac2bfc

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	tools/skp/webpages_playback.py	View		4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780493002/1

6 years ago (2014-12-03 12:29:02 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-03 12:38:52 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e75d2d2d995dad4eeed1bd306ef987adabac2bfc

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages