Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780343002: Remove always true guard (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
Reviewers:
jam, kbalazs, ostap, dcheng
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, posciak+watch_chromium.org, James Su, wjia+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove always true guard #if defined(OS_MACOSX) || defined(USE_AURA) || defined(OS_ANDROID) This guard will always return true. This cl will remove all the unnecessary guard Committed: https://crrev.com/2d94f22b5794155dcd05eb6382b105c34ba67494 Cr-Commit-Position: refs/heads/master@{#307306}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add guard #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -40 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/input_messages.h View 1 2 3 4 1 chunk +2 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 3 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 6 chunks +0 lines, -10 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
zhaoze.zhou
jam@chromium.org: Hi can you take a look? https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&q=common.gy&sq=package:chromium&l=99 In common.gypi, when chromeos==1 or OS=="win" or ...
6 years ago (2014-12-05 22:52:50 UTC) #4
zhaoze.zhou
dcheng@chromium.org: Hi, can you take a look? thanks.
6 years ago (2014-12-05 22:56:05 UTC) #6
dcheng
https://codereview.chromium.org/780343002/diff/80001/content/common/input_messages.h File content/common/input_messages.h (right): https://codereview.chromium.org/780343002/diff/80001/content/common/input_messages.h#newcode257 content/common/input_messages.h:257: // On Mac and Aura IME can request composition ...
6 years ago (2014-12-05 23:45:50 UTC) #7
jam
lgtm
6 years ago (2014-12-06 00:36:33 UTC) #8
zhaoze.zhou
https://codereview.chromium.org/780343002/diff/80001/content/common/input_messages.h File content/common/input_messages.h (right): https://codereview.chromium.org/780343002/diff/80001/content/common/input_messages.h#newcode257 content/common/input_messages.h:257: // On Mac and Aura IME can request composition ...
6 years ago (2014-12-08 14:51:16 UTC) #9
dcheng
input_messages.h LGTM
6 years ago (2014-12-08 18:38:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780343002/100001
6 years ago (2014-12-08 18:40:57 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
6 years ago (2014-12-08 19:48:15 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-08 19:49:40 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/2d94f22b5794155dcd05eb6382b105c34ba67494
Cr-Commit-Position: refs/heads/master@{#307306}

Powered by Google App Engine
This is Rietveld 408576698