Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 780333004: Make d8 default to standard location for external snapshots. (Closed)

Created:
6 years ago by vogelheim
Modified:
6 years ago
Reviewers:
yangguo, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Make d8 default to standard location for external snapshots. This makes tests runnable with the external snapshot, and should be the last step before enabling external snapshot on >=1 bots. R=yangguo BUG=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M src/d8.cc View 3 chunks +34 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vogelheim
6 years ago (2014-12-10 15:30:15 UTC) #3
Yang
On 2014/12/10 15:30:15, vogelheim wrote: lgtm. But for the record, I'd have preferred having the ...
6 years ago (2014-12-10 15:57:24 UTC) #4
vogelheim
On 2014/12/10 15:57:24, Yang wrote: > On 2014/12/10 15:30:15, vogelheim wrote: > > lgtm. But ...
6 years ago (2014-12-10 16:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/780333004/40001
6 years ago (2014-12-10 16:09:36 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-10 16:36:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698